[webkit-reviews] review granted: [Bug 43746] Port view-source to new parser : [Attachment 64066] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 43746: Port view-source to new parser
https://bugs.webkit.org/show_bug.cgi?id=43746

Attachment 64066: Patch
https://bugs.webkit.org/attachment.cgi?id=64066&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Slightly sad you weren't able to make the String constructor work.  It probably
had to be a template itself or something.

WebCore/html/HTMLToken.h:75
 +	int startIndex() const { return m_range.m_start; }
Feels slightly odd to not just expose the Range object, but seems fine.

WebCore/html/HTMLViewSourceParser.cpp:41
 +	ASSERT_NOT_REACHED();
I'm surprised you have to implement insert()

WebCore/html/HTMLViewSourceParser.cpp:79
 +	// FIXME: The tokenizer should do this work for us.
I don't understand what you mean here.	Could you file a bug?

Looks great!