[webkit-reviews] review granted: [Bug 43754] Use Chromium OpenGL bindings rather than GLEW in WebGraphicsContextDefaultImpl : [Attachment 64032] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 43754: Use Chromium OpenGL bindings rather than GLEW in
WebGraphicsContextDefaultImpl
https://bugs.webkit.org/show_bug.cgi?id=43754

Attachment 64032: Patch
https://bugs.webkit.org/attachment.cgi?id=64032&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, after style fixes:

WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:72
 +	, m_glContext(NULL)
(0)

WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:98
 +	    delete m_glContext;
Maybe make OwnPtr?

WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:107
 +	m_glContext = gfx::GLContext::CreateOffscreenGLContext(NULL);
(0)

WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:427
 +	// TODO(apatrick): OpenGL ES 2 does not support GL_BGRA so this fails
when
FIXME: