[webkit-reviews] review denied: [Bug 43793] Date("") should be an invalid date time : [Attachment 64013] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 43793: Date("") should be an invalid date time
https://bugs.webkit.org/show_bug.cgi?id=43793

Attachment 64013: Patch
https://bugs.webkit.org/attachment.cgi?id=64013&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Why should new Date("") be NaN? Can you point to a part of a spec, or the
behavior of another browser? As a general rule, it's better for your ChangeLog
to explain the why, rather than the what.

>      cachedDateString = UString();
> +    cachedDateStringValue = NaN;

Can you explain why you needed to make this change?

UString() should not be == to UString(""). If it is, I think we have another
bug to solve.