[webkit-reviews] review granted: [Bug 43788] Web Inspector: move databse processing to native layer. : [Attachment 64007] [PATCH] Proposed change. Will add to XCode proj on landing.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 10 06:45:49 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 43788: Web Inspector: move databse processing to native layer.
https://bugs.webkit.org/show_bug.cgi?id=43788

Attachment 64007: [PATCH] Proposed change. Will add to XCode proj on landing.
https://bugs.webkit.org/attachment.cgi?id=64007&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/InspectorBackend.cpp:139
 +	*transactionId =
m_inspectorController->m_storageAgent->executeSQL(database, query);
Please introduce a getter for storage agent as we do for other agents.

WebCore/inspector/InspectorStorageAgent.h:34
 +  #include "wtf/PassOwnPtr.h"
should be <wtf/PassRefPtr.h> ?

WebCore/inspector/InspectorStorageAgent.cpp:49
 +  #include "wtf/Vector.h"
<wtf/Vector.h>

WebCore/inspector/InspectorStorageAgent.cpp:39
 +  #include "SQLValue.h"
wrong include order


More information about the webkit-reviews mailing list