[webkit-reviews] review requested: [Bug 42811] Geolocation preemptive permissions policy is buggy : [Attachment 63997] patch

[bugzilla-daemon at webkit.org]

Mahesh Kulkarni <mahesh.kulkarni at nokia.com> has asked  for review:
Bug 42811: Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811

Attachment 63997: patch
https://bugs.webkit.org/attachment.cgi?id=63997&action=review

------- Additional Comments from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>
Incorporates changes as per comment #6

- when notifier->hasZeroTimeout() is set, immediate call back has to be given

- permission pending notifiers will be added before startUpdating() called to
make starRequest() more readble. 
  This also means that when makeCachedPositionCallbacks() calls startupdating()
no redundant permission checks happen

- added handlePendingPermissionNotifiers() to make setIsAllowed() more
readable. 

- m_service->startUpdate() is called in case of !CLIENT_BASED_GEOLOCATION &&
PREEMPT_GEOLOCATION_PERMISSION clients on successful permission set.
  We could add a layout test for this but that would mean we have to enable
PREEMPT_GEOLOCATION_PERMISSION for MockGeolocationService. Please comment.