[webkit-reviews] review requested: [Bug 43735] C++ DOM binding classes with private structs need operator= overload : [Attachment 63974] Patch updated with bindings test outputs updated.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 9 21:48:47 PDT 2010


Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 43735: C++ DOM binding classes with private structs need operator= overload
https://bugs.webkit.org/show_bug.cgi?id=43735

Attachment 63974: Patch updated with bindings test outputs updated.
https://bugs.webkit.org/attachment.cgi?id=63974&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Thanks for catching the bindings test updates! I didn't realize these were in
the tree. New patch up now with them added.

Note that there are a couple other changes (with the ENABLE(Conditional)) in
one of the test headers as well, this is from a change in a previous commit
(the C++ DOM bindings wasn't enclosing the function definitions with the
conditional #if, only their implementations) and the results are correct.


More information about the webkit-reviews mailing list