[webkit-reviews] review granted: [Bug 43745] Allow an assembler/macroassembler to compact branches to more concise forms when linking : [Attachment 63964] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 43745: Allow an assembler/macroassembler to compact branches to more
concise forms when linking
https://bugs.webkit.org/show_bug.cgi?id=43745

Attachment 63964: Patch
https://bugs.webkit.org/attachment.cgi?id=63964&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
> void breakpoint(uint8_t imm = 0)

The macroassembler interface should be identical for all platforms.  (Hmmm, we
should probably have a better way of enforcing this; maybe we should make
MacroAssembler privately inherit from MacroAssemblerBase & add wrapper methods
to enforce a single API).  If breakpoint is going to take a uint8_t it really
has to do so on all platforms, but since this might be difficult to usefully
implement on other architectures I think a better solution would be to revert
this change at this level (still add to ARMv7Assembler).  That way you can
still use m_assembler.bkpt(N); when debugging on ARMv7.

Please remove teh thousands of ", 0"s, restore default argy goodness.