[webkit-reviews] review denied: [Bug 43742] Fast-path for array lookup with double subscript : [Attachment 63921] Proposed patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 43742: Fast-path for array lookup with double subscript
https://bugs.webkit.org/show_bug.cgi?id=43742

Attachment 63921: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=63921&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
This is incorrect. 1.5 is a valid property, eg.
a=[];
a[1.5] = "Foo"

a["1.5"] === "Foo"; // true
a[1] === undefined; // true

Your patch results in a look up of 1.5 converting to a lookup of 1, which is
incorrect.  It's somewhat worrying that this passes tests :-(

Is the double that's being looked up actually an integral value?

--Oliver