[webkit-reviews] review denied: [Bug 43726] Web Inspector: remove InspectorFrontend : [Attachment 63899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 9 09:14:52 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 43726: Web Inspector: remove InspectorFrontend
https://bugs.webkit.org/show_bug.cgi?id=43726

Attachment 63899: Patch
https://bugs.webkit.org/attachment.cgi?id=63899&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
LayoutTests/http/tests/inspector/inspector-test.js:39
 +		{
Nit: strange indentation.

LayoutTests/http/tests/inspector-enabled/resources/console-log-frame-after-navi
gation.html:5
 +  setTimeout(function() {
Does not belong to this change.

WebCore/inspector/InspectorController.cpp:474
 +  void InspectorController::connectFrontend(const ScriptObject&)
Remove this parameter as a whole? r- for this!

WebCore/inspector/InspectorController.cpp:478
 +	m_remoteFrontend = new RemoteInspectorFrontend(m_client);
InspectorFrontend is dead. Long live InspectorFrontend.
In other words: let rename RemoteInspectorFrontend to InspectorFrontend!


More information about the webkit-reviews mailing list