[webkit-reviews] review denied: [Bug 43115] [Qt] QScriptValue should hhave API for accessing a private data. : [Attachment 62814] Fix v1

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 43115: [Qt] QScriptValue should hhave API for accessing a private data.
https://bugs.webkit.org/show_bug.cgi?id=43115

Attachment 62814: Fix v1
https://bugs.webkit.org/attachment.cgi?id=62814&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
> +	   [Qt] QScriptValue should hhave API for accessing a private data.

Typo at "hhave".

> +    QExplicitlySharedDataPointer<QScriptValuePrivate> m_objectData;

Can't you use the new QSharedPointer instead?

> +QScriptValuePrivate* QScriptValuePrivate::data() const
> +{
> +    if (m_objectData)
> +	   return m_objectData.data();
> +    return new QScriptValuePrivate();
> +}

Is this asking for a leak? If there is a way to use QSharedPointer, we can even
pass QSharedPointer back instead of raw pointer?

r- for these minor issues. Otherwise LGTM.