[webkit-reviews] review denied: [Bug 43687] Web Inspector: speed-up Element.prototype.removeChildren : [Attachment 63840] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 8 05:11:36 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Nikita Vasilyev
<me at elv1s.ru>'s request for review:
Bug 43687: Web Inspector: speed-up Element.prototype.removeChildren
https://bugs.webkit.org/show_bug.cgi?id=43687

Attachment 63840: patch
https://bugs.webkit.org/attachment.cgi?id=63840&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
In fact I've done the opposite optimization earlier:
https://bugs.webkit.org/show_bug.cgi?id=31160

Timeline was lagging visually on scrolling and clearing + shark was showing
this to be the slow operation. I'd suggest that you try those. Wrt benchmarks,
I think they lack listeners - adding those would change the WebKit picture a
lot. I know that the bindings have improved, but still, single call to native
will always be ways faster.


More information about the webkit-reviews mailing list