[webkit-reviews] review denied: [Bug 43531] Web Inspector: Support appcache status change for Chrome : [Attachment 63647] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Aug 7 03:10:57 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied Kavita Kanetkar
<kkanetkar at chromium.org>'s request for review:
Bug 43531: Web Inspector: Support appcache status change for Chrome
https://bugs.webkit.org/show_bug.cgi?id=43531
Attachment 63647: proposed fix
https://bugs.webkit.org/attachment.cgi?id=63647&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebKit/chromium/src/ApplicationCacheHost.cpp:209
+ if (page && page->inspectorController()->inspectorFrontend() &&
page->mainFrame() == m_documentLoader->frame())
You should not make ApplicationCacheHost too much involved into the
InspectorController's business. inspectorFrontend() should not be used as
indication of the frontend availability + it will actually go away this week.
You should notify inspector controller on any change and let it decide when to
trigger the action.
WebKit/chromium/src/ApplicationCacheHost.cpp:210
+
page->inspectorController()->applicationCacheAgent()->updateApplicationCacheSta
tus(status());
So you will simply check applicationCacheAgent for being 0, and if not, notify
it.
More information about the webkit-reviews
mailing list