[webkit-reviews] review canceled: [Bug 40518] [GTK] Last Hangul letter is typed again when a composition is finished with mouse press : [Attachment 63137] Proposed Patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 7 02:08:53 PDT 2010


Joone Hur <joone at kldp.org> has canceled Joone Hur <joone at kldp.org>'s request
for review:
Bug 40518: [GTK] Last Hangul letter is typed again when a composition is
finished with mouse press
https://bugs.webkit.org/show_bug.cgi?id=40518

Attachment 63137: Proposed Patch3
https://bugs.webkit.org/attachment.cgi?id=63137&action=review

------- Additional Comments from Joone Hur <joone at kldp.org>
I updated the patch according to Martin's review except applying the code
below.

if (!targetFrame->editor()->hasComposition())
	return;

Because, the above code can't check whether a composition completes when a
mouse press fires at a different editing position.


More information about the webkit-reviews mailing list