[webkit-reviews] review granted: [Bug 43618] Generalize SVGPathParser to allow more than just strings as input source : [Attachment 63806] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 23:12:10 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 43618: Generalize SVGPathParser to allow more than just strings as input
source
https://bugs.webkit.org/show_bug.cgi?id=43618

Attachment 63806: Patch
https://bugs.webkit.org/attachment.cgi?id=63806&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r=me, some minor nitpicks before you land:

WebCore/ChangeLog:12
 +	    Moved the SVGPathSegType enumeration from SVGPathSeg class for a
common use across
Moved the SVGPathSegType enum from SVGPathSeg class in WebCore namespace, for
easier access throughout the SVG code.

WebCore/ChangeLog:15
 +	    No new tests added.
Doesn't affect any tests, sounds better, creates less worries :-)

WebCore/svg/SVGPathParser.cpp:320
 +	ASSERT(m_source);
Also add ASSERT(m_consumer) here.

WebCore/svg/SVGPathParser.h:44
 +	void setCurrentSource(SVGPathSource* source) { m_source = source;}
Space should be added before ned brace.

WebCore/svg/SVGPathStringSource.cpp:131
 +	if ((*m_current == '+' || *m_current == '-' || *m_current == '.' ||
*m_current >= '0' && *m_current <= '9')

Ah,  I misread before, didn't see there was another statement on the next line.
Please readd the braces around *m_current >= '0' ...


More information about the webkit-reviews mailing list