[webkit-reviews] review requested: [Bug 43173] [WML] Add KURL parameter to WMLDocument::create() : [Attachment 63795] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 19:22:40 PDT 2010


Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 43173: [WML] Add KURL parameter to WMLDocument::create()
https://bugs.webkit.org/show_bug.cgi?id=43173

Attachment 63795: Patch
https://bugs.webkit.org/attachment.cgi?id=63795&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
(In reply to comment #3)
> (From update of attachment 62919 [details])
> Why?	Neither your bug or your ChangeLog say why?
> 
> Is this a build fix?

Yes, right.  This patch is to fix build break.

WMLDocument inherits Document class as below,

    WMLDocument::WMLDocument(Frame* frame)
       : Document(frame, false, false)

However, the Document Class's construct parameters were changed. url was added.


    Document::Document(Frame* frame, const KURL& url, bool isXHTML, bool
isHTML)

So. I make this patch to fix build break when wml is enabled.

I add comment to Changelog.


More information about the webkit-reviews mailing list