[webkit-reviews] review granted: [Bug 43362] Accelerated 2d canvases should get compositing layers : [Attachment 63778] add missing UNUSED_PARAM()

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 43362: Accelerated 2d canvases should get compositing layers
https://bugs.webkit.org/show_bug.cgi?id=43362

Attachment 63778: add missing UNUSED_PARAM()
https://bugs.webkit.org/attachment.cgi?id=63778&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

> +#if ENABLE(ACCELERATED_2D_CANVAS)
> +    if (Page* p = canvas->document()->page()) {
> +	   if (p->settings()->accelerated2dCanvasEnabled()) {
> +	       if (FrameView* view = canvas->document()->view()) {
> +		   if (ScrollView* rootView = view->root()) {
> +		       if (HostWindow* hostWindow = view->root()->hostWindow())
{
> +			   // Set up our context
> +			   GraphicsContext3D::Attributes attr;
> +			   attr.stencil = true;
> +			   m_context3D = GraphicsContext3D::create(attr,
hostWindow);
> +			   if (m_context3D)
> +			       if (GraphicsContext* c = drawingContext())
> +				   c->setGraphicsContext3D(m_context3D.get(),
IntSize(canvas->width(), canvas->height()));
> +		       }
> +		   }
> +	       }
> +	   }
> +    }

Some early returns would help with readability here.