[webkit-reviews] review requested: [Bug 43635] [Qt] Flash content can not be displayed by Symbian Flash Player : [Attachment 63770] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 15:30:06 PDT 2010


Hui Huang <hui_huang at yahoo.com> has asked  for review:
Bug 43635: [Qt] Flash content can not be displayed by Symbian Flash Player
https://bugs.webkit.org/show_bug.cgi?id=43635

Attachment 63770: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=63770&action=review

------- Additional Comments from Hui Huang <hui_huang at yahoo.com>
When plug-in is being created, m_windowRect is not updated in
updatePluginWidget because the parent of PluginView is not set:
void PluginView::updatePluginWidget()
{
    if (!parent())
	return;
...

Plug-in gets wrong window size (both height and width are 0) on setwindow.
Flash content is not displayed. Calling updatePluginWidget() after plug-in is
successfully loaded in PluginView::setParent fixed the problem. The proposed
patch was tested successfully on S60 emulator.


More information about the webkit-reviews mailing list