[webkit-reviews] review denied: [Bug 41614] RegExp constructor should throw a SyntaxError if invalid flags are specified : [Attachment 62187] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 6 15:05:39 PDT 2010
Oliver Hunt <oliver at apple.com> has denied Kent Hansen <kent.hansen at nokia.com>'s
request for review:
Bug 41614: RegExp constructor should throw a SyntaxError if invalid flags are
specified
https://bugs.webkit.org/show_bug.cgi?id=41614
Attachment 62187: Patch
https://bugs.webkit.org/attachment.cgi?id=62187&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
provisional r- -- if you can convince me that the "error" constructor is
necessary i'll r+ this, but currently it seems really hacky.
JavaScriptCore/runtime/RegExpCache.cpp:40
+ return RegExp::createWithInvalidFlags();
Why return a new "magic" regexp rather than null?
More information about the webkit-reviews
mailing list