[webkit-reviews] review denied: [Bug 41842] Add feature detection support for NRWT : [Attachment 61033] proposed_patch_v2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Gabor Rapcsanyi
<rgabor at inf.u-szeged.hu>'s request for review:
Bug 41842: Add feature detection support for NRWT
https://bugs.webkit.org/show_bug.cgi?id=41842

Attachment 61033: proposed_patch_v2
https://bugs.webkit.org/attachment.cgi?id=61033&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
With this implemented, we can also now remove some hacks in:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/
port/webkit.py#L220

Yeah, this is not the right layer.

Some platform-specific function should do the symbol search and return an array
of symbols. Then webkit.py should do the lookup in the list of conversions.

The ports don't really have to do anything.  Except right now port and platform
abstractions are mashed totether, so the port will ahve to act as the platform
here, and do the search.

I would just implement this all in webkit.py, except for the library path
lookup of course.

This is close, but not quite right.

Also, this needs unit tests.