[webkit-reviews] review denied: [Bug 43606] dump-as-markup should work in Firefox : [Attachment 63687] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 13:22:16 PDT 2010


Ojan Vafai <ojan at chromium.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 43606: dump-as-markup should work in Firefox
https://bugs.webkit.org/show_bug.cgi?id=43606

Attachment 63687: Patch
https://bugs.webkit.org/attachment.cgi?id=63687&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +++ b/LayoutTests/ChangeLog
> +	   Apparently Firefox lacks this API.

I think something else is going wrong here.
document.body.ownerDocument.defaultView.getSelection() returns a selection
object in Firefox. Does this fail for all dump-as-markup tests? Does it throw
an exception?


More information about the webkit-reviews mailing list