[webkit-reviews] review granted: [Bug 43637] Add CoreIPC::MessageReceiver class : [Attachment 63753] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 43637: Add CoreIPC::MessageReceiver class
https://bugs.webkit.org/show_bug.cgi?id=43637

Attachment 63753: Patch
https://bugs.webkit.org/attachment.cgi?id=63753&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  class Connection : public ThreadSafeShared<Connection> {
>  public:
> -    class Client {
> +    class MessageReceiver {
> +    public:
> +	   virtual ~MessageReceiver() { }

It would be slightly for the destructor to be protected.

> +++ b/WebKit2/Shared/DrawingAreaBase.h
> @@ -27,18 +27,13 @@
>  #define DrawingAreaBase_h
>  
>  #include "ArgumentCoders.h"
> +#include "Connection.h"
>  
>  namespace WebCore {
>      class IntRect;
>      class IntSize;
>  }
>  
> -namespace CoreIPC {
> -    class ArgumentDecoder;
> -    class Connection;
> -    class MessageID;
> -}
> -

This change makes me a little sad.

r=me