[webkit-reviews] review requested: [Bug 43362] Accelerated 2d canvases should get compositing layers : [Attachment 63692] Patch

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 43362: Accelerated 2d canvases should get compositing layers
https://bugs.webkit.org/show_bug.cgi?id=43362

Attachment 63692: Patch
https://bugs.webkit.org/attachment.cgi?id=63692&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
WebCore/html/canvas/CanvasRenderingContext2D.cpp:134
 +  #endif


Having a setGraphicsContext3D method on the platformContext seems wrong.
PlatformGraphicsContext is a platform specific class which often isn't even a
C++ class. I think it would be better to just add setGraphicsContext3D() to
GraphicsContext itself and have the platform specific code do what it needs to
do. This will also allow the default implementation of setGraphicsContext3D to
have a compile-time failure so builders will get an indication that in addition
to enabling ACCELERATED_2D_CANVAS you need to implement for it in
GraphicsContext.



WebCore/html/canvas/CanvasRenderingContext2D.cpp:151
 +  #endif


Why aren't you doing the accelerated2dCanvasEnabled() test here like above?