[webkit-reviews] review granted: [Bug 42958] Pasting should fire textInput event : [Attachment 63674] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 6 09:24:55 PDT 2010
Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 42958: Pasting should fire textInput event
https://bugs.webkit.org/show_bug.cgi?id=42958
Attachment 63674: Patch
https://bugs.webkit.org/attachment.cgi?id=63674&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
In general, using enums instead of bools is preferred for readability. But I
realize that some of this is historic for smart replace and match style. A
good follow up patch would be to convert these bools to enums across all the
editing code.
WebCore/dom/TextEvent.cpp:56
+ , m_isBackTab(false)
Nit: Please initialize the bools here too.
More information about the webkit-reviews
mailing list