[webkit-reviews] review granted: [Bug 43494] mac-wk2/Skipped should be used on Windows when running regression tests : [Attachment 63710] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 43494: mac-wk2/Skipped should be used on Windows when running regression
tests
https://bugs.webkit.org/show_bug.cgi?id=43494

Attachment 63710: Patch
https://bugs.webkit.org/attachment.cgi?id=63710&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -    foreach my $level (@platformTestHierarchy) {
> +    my @skippedFilePaths = @platformTestHierarchy;

I'd call this @skippedFileDirectories, since it contains paths to directories
that contain Skipped files, rather than paths to Skipped files themselves.

> +    # Because nearly all of the skipped tests for WebKit 2 on Mac are due to

> +    # cross-platform issues, Windows will use both the Mac and Windows
skipped
> +    # lists to avoid maintaining separate lists.
> +    if ($platform eq "win-wk2") {
> +	   push(@skippedFilePaths, catdir($platformBaseDirectory, "mac-wk2"));
> +    }

For a single-line branch like this it's often nicer to write it using this
syntax:

push(@skippedFilePaths, catdir($platformBaseDirectory, "mac-wk2")) if $platform
eq "win-wk2";

r=me