[webkit-reviews] review granted: [Bug 40788] [GTK] Support for image drags : [Attachment 59012] Add image dragging support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 04:51:35 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 40788: [GTK] Support for image drags
https://bugs.webkit.org/show_bug.cgi?id=40788

Attachment 59012: Add image dragging support
https://bugs.webkit.org/attachment.cgi?id=59012&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 314 void ClipboardGtk::declareAndWriteDragImage(Element* element, const KURL&
url, const String& label, Frame* frame)
314315 {
315 	 CachedImage* cachedImage = getCachedImage(element);
316 	 if (!cachedImage || !cachedImage->isLoaded())
 316	 m_dataObject->setURL(url, label);
 317	 m_dataObject->setMarkup(createMarkup(element, IncludeNode, 0,
AbsoluteURLs));
 318 
 319	 CachedImage* image = getCachedImage(element);
 320	 if (!image || !image->isLoaded())
317321	       return;

So what happens if there is no image? You can then paste the URL or the markup,
but not the image, and that's all? Thanks!


More information about the webkit-reviews mailing list