[webkit-reviews] review granted: [Bug 42865] Implement AccelerometerEvent : [Attachment 63556] yet another style fix

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 42865: Implement AccelerometerEvent
https://bugs.webkit.org/show_bug.cgi?id=42865

Attachment 63556: yet another style fix
https://bugs.webkit.org/attachment.cgi?id=63556&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +	   https://bugs.webkit.org/show_bug.cgi?id=42865
> +	   Implement AccelerometerEvent

You mean the DeviceMotion event?

> +	   Implement the DeviceMotionEvent interface as defined
> +	   in http://dev.w3.org/geo/api/spec-source-orientation.html
> +	   This is currently an empty implementation, in that there is
> +	   no motion client connected - the platform implementations
> +	   will need to do that.
> +
> +	   Note also that at this time the specified event is
> +	   called Accelerometer, but this will change to DeviceMotion
> +	   with the inclusion of gyroscopic results.

I think you should remove this from the Changelog; it will go stale as soon
as the spec changes.



>			<File
> +			       
RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSDeviceMoti
onEvent.cpp"
> +				>
> +				<FileConfiguration
> +					Name="Debug|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Release|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_Internal|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_Cairo|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Release_Cairo|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_All|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>

Not sure if you should include all that gubbins.

> +					<FileConfiguration
> +						Name="Debug|Win32"
> +						ExcludedFromBuild="true"
> +						>
> +						<Tool
> +							Name="VCCLCompilerTool"

> +						/>
> +					</FileConfiguration>
> +					<FileConfiguration
> +						Name="Release|Win32"
> +						ExcludedFromBuild="true"
> +						>
> +						<Tool
> +							Name="VCCLCompilerTool"

> +						/>
> +					</FileConfiguration>
> +					<FileConfiguration
> +						Name="Debug_Internal|Win32"
> +						ExcludedFromBuild="true"
> +						>
> +						<Tool
> +							Name="VCCLCompilerTool"

> +						/>
> +					</FileConfiguration>
> +					<FileConfiguration
> +						Name="Debug_Cairo|Win32"
> +						ExcludedFromBuild="true"
> +						>
> +						<Tool
> +							Name="VCCLCompilerTool"

> +						/>
> +					</FileConfiguration>
> +					<FileConfiguration
> +						Name="Release_Cairo|Win32"
> +						ExcludedFromBuild="true"
> +						>
> +						<Tool
> +							Name="VCCLCompilerTool"

> +						/>
> +					</FileConfiguration>
> +					<FileConfiguration
> +						Name="Debug_All|Win32"
> +						ExcludedFromBuild="true"
> +						>
> +						<Tool
> +							Name="VCCLCompilerTool"

> +						/>
> +					</FileConfiguration>

Ditto.

> diff --git a/WebCore/WebCore.xcodeproj/project.pbxproj
b/WebCore/WebCore.xcodeproj/project.pbxproj


>			isa = PBXProject;
>			buildConfigurationList = 149C284308902B11008A9EFC /*
Build configuration list for PBXProject "WebCore" */;
>			compatibilityVersion = "Xcode 2.4";
> +			developmentRegion = English;
>			hasScannedForEncodings = 1;

Spurious change (but harmless).

> diff --git a/WebCore/dom/DeviceMotionClient.h
b/WebCore/dom/DeviceMotionClient.h

> +    virtual DeviceMotionData* currentDeviceMotion() const = 0;

I think this should return a const DeviceMotionData*, or const
DeviceMotionData&,
or something refcounted.

> diff --git a/WebCore/dom/EventNames.h b/WebCore/dom/EventNames.h
> index 6620cec..235988a 100644
> --- a/WebCore/dom/EventNames.h
> +++ b/WebCore/dom/EventNames.h
> @@ -50,6 +50,7 @@ namespace WebCore {
>      macro(copy) \
>      macro(cut) \
>      macro(dblclick) \
> +    macro(devicemotion) \

I wonder if this should have a "webkit" prefix, since things are
still in flux.