[webkit-reviews] review requested: [Bug 43531] Web Inspector: Support appcache status change for Chrome : [Attachment 63647] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 15:33:27 PDT 2010


Kavita Kanetkar <kkanetkar at chromium.org> has asked  for review:
Bug 43531: Web Inspector: Support appcache status change for Chrome
https://bugs.webkit.org/show_bug.cgi?id=43531

Attachment 63647: proposed fix
https://bugs.webkit.org/attachment.cgi?id=63647&action=review

------- Additional Comments from Kavita Kanetkar <kkanetkar at chromium.org>
Here, the appcache status update piggybacks off
ApplicationCacheHost::notifyDOMApplicationCache()
and pushes the status to inspector frontend via an *expensive* call status().

So is the check for:
page->inspectorController()->inspectorFrontend()

sufficient to guarantee that inspector is launched and only for that page? 
I did look through the code and looks like disconnectFrontend() is called if
there's no frontend open.
Again, if frontend is connected for other pages,
page->inspectorController()->inspectorFrontend() 
will still be NULL if this particular appcache host's page does not have
inspector open. Am I correct?

Thanks!


More information about the webkit-reviews mailing list