[webkit-reviews] review granted: [Bug 43579] js-test-pre.js's escapeHTML should escape null characters so we can see them : [Attachment 63637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 14:46:43 PDT 2010


Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 43579: js-test-pre.js's escapeHTML should escape null characters so we can
see them
https://bugs.webkit.org/show_bug.cgi?id=43579

Attachment 63637: Patch
https://bugs.webkit.org/attachment.cgi?id=63637&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    return text.replace(/&/g, "&amp;").replace(/</g, "&lt;");
> +    return text.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/\0/g,
"\\0");

I was thinking we should chose a form that can be parsed such as &#0; but
perhaps there is no such thing.

r=me


More information about the webkit-reviews mailing list