[webkit-reviews] review denied: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 63626] FullScreen-WebCore-IDL

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099

Attachment 63626: FullScreen-WebCore-IDL
https://bugs.webkit.org/attachment.cgi?id=63626&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

> Index: WebCore/dom/WebKitFullScreenChangeEvent.idl
> ===================================================================

> +module events {
> +
> +    interface [
> +	   Conditional=WORKERS&FULLSCREEN_API,

Why WORKERS?

> +	   NoStaticTables
> +    ] WebKitFullScreenChangeEvent : Event {
> +
> +	   void initWebKitFullScreenChangeEvent(in DOMString eventTypeArg, 
> +					 in boolean canBubbleArg, 
> +					 in boolean cancelableArg);
> +    };
> +
> +}
> Index: WebCore/html/HTMLElement.idl
> ===================================================================
> --- WebCore/html/HTMLElement.idl	(revision 64653)
> +++ WebCore/html/HTMLElement.idl	(working copy)
> @@ -64,6 +64,11 @@ module html {
>  #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
>	   readonly attribute DOMString titleDisplayString;
>  #endif
> +
> +#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
> +	   void webkitRequestFullScreen();
> +	   void webkitRequestFullScreenWithKeys();
> +#endif

Why do you need these here? HTMLElement derives from Element.