[webkit-reviews] review denied: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 63624] FullScreen-WebCore-Config

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099

Attachment 63624: FullScreen-WebCore-Config
https://bugs.webkit.org/attachment.cgi?id=63624&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: JavaScriptCore/wtf/Platform.h
> ===================================================================
> --- JavaScriptCore/wtf/Platform.h	(revision 64653)
> +++ JavaScriptCore/wtf/Platform.h	(working copy)
> @@ -594,6 +594,7 @@
>  #endif
>  #define HAVE_READLINE 1
>  #define HAVE_RUNLOOP_TIMER 1
> +#define ENABLE_FULLSCREEN_API 1

I think this should go along with the things like:

#if !defined(ENABLE_DRAG_SUPPORT)
#define ENABLE_DRAG_SUPPORT 1
#endif

and default to 0. It will get enabled via the xconfig files on platforms that
want it.

The rest of this patch doesn't stand alone, because it's adding new files to
the projects without supplying the new files.