[webkit-reviews] review denied: [Bug 36171] [QT] QtWebKit doesn't support NPAPI for DirectFB : [Attachment 63633] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 14:22:54 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Anders Bakken
<agbakken at gmail.com>'s request for review:
Bug 36171: [QT] QtWebKit doesn't support NPAPI for DirectFB
https://bugs.webkit.org/show_bug.cgi?id=36171

Attachment 63633: Patch
https://bugs.webkit.org/attachment.cgi?id=63633&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
This seems very isolated apart from the XP_UNIX -> XP_X11 change which I'm not
sure about, so I tending to give you a r=me.

Could you please answer my question regarding this before committing?

Ah, unfortunately I will have to give you an r-, due to the patch missing files
such as the PluginViewQtDFB.cpp etc.


More information about the webkit-reviews mailing list