[webkit-reviews] review granted: [Bug 43524] Add DOM Node wrapper class for injected bundle : [Attachment 63610] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 43524: Add DOM Node wrapper class for injected bundle
https://bugs.webkit.org/show_bug.cgi?id=43524

Attachment 63610: Patch
https://bugs.webkit.org/attachment.cgi?id=63610&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
> Index: WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
> ===================================================================
> --- WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp       
(revision 0)
> +++ WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp       
(revision 0)

> +
> +static DOMHandleCache& domHandleCache()
> +{
> +    static DOMHandleCache cache;

This should use DEFINE_STATIC_LOCAL to avoid an exit time destructor.

> +PassRefPtr<InjectedBundleNodeHandle> InjectedBundleNodeHandle::get(Node*
node)

I prefer the name getOrCreate here.