[webkit-reviews] review denied: [Bug 43117] Chromium regression when viewing a plugin document with plugins disabled : [Attachment 63588] Remove assertion from PluginDocumentParser::appendBytes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 10:37:46 PDT 2010


Eric Seidel <eric at webkit.org> has denied  review:
Bug 43117: Chromium regression when viewing a plugin document with plugins
disabled
https://bugs.webkit.org/show_bug.cgi?id=43117

Attachment 63588: Remove assertion from PluginDocumentParser::appendBytes
https://bugs.webkit.org/attachment.cgi?id=63588&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
If the "fix" is to remove the ASSERT, we should instead replace it with:

ASSERT_ARG(length, !m_embedElement || !length);


More information about the webkit-reviews mailing list