[webkit-reviews] review granted: [Bug 43470] Chromium buildbot: Avoid "zip" command dependency : [Attachment 63558] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 5 09:47:05 PDT 2010
Tony Chang (Google) <tony at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 43470: Chromium buildbot: Avoid "zip" command dependency
https://bugs.webkit.org/show_bug.cgi?id=43470
Attachment 63558: Patch 2
https://bugs.webkit.org/attachment.cgi?id=63558&action=review
------- Additional Comments from Tony Chang (Google) <tony at chromium.org>
> diff --git a/WebKitTools/BuildSlaveSupport/test-result-archive
b/WebKitTools/BuildSlaveSupport/test-result-archive
> + for dirPath, dirNames, fileNames in os.walk(file):
> + for fileName in fileNames:
> + relativePath = os.path.join(dirPath, fileName)
> + print "Adding ", relativePath
Nit: I think print automatically puts a space between each argument. Not a big
deal, but I think this puts 2 spaces between "Adding" and the path. Same
below.
More information about the webkit-reviews
mailing list