[webkit-reviews] review granted: [Bug 43554] Way too many encoding aliases are treated as valid : [Attachment 63585] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 43554: Way too many encoding aliases are treated as valid
https://bugs.webkit.org/show_bug.cgi?id=43554

Attachment 63585: proposed patch
https://bugs.webkit.org/attachment.cgi?id=63585&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +// If passed any non-ASCII characters, depends on the behavior of isalnum --

> +// if that returns false as it does on OS X, then it will properly skip
those
> +// characters too.

This comment is not true, and should be removed.

>  struct TextEncodingNameHash {

With the changes you have made, is TextEncodingNameHash different from
CaseFoldingHash? Can we just use CaseFoldingHash instead?

> +    if (0 == strcmp(alias, "8859_1"))
> +	   return true;

Would be good to add a comment explaining why we don't want this alias.

Generally speaking this seems like a good patch, but I am slightly worried
about backward compatibility.