[webkit-reviews] review granted: [Bug 43341] Canvas is not reset when setting canvas.width : [Attachment 63534] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 43341: Canvas is not reset when setting canvas.width
https://bugs.webkit.org/show_bug.cgi?id=43341

Attachment 63534: Patch
https://bugs.webkit.org/attachment.cgi?id=63534&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    bool ok;
> +    bool ok, hadImageBuffer = hasCreatedImageBuffer();

The two booleans should be defined on separate lines. We don't do two on one
line like this in WebKit.

> Index: LayoutTests/fast/repaint/setWidthResetAfterForcedRender.html

While this does involve "repainting", I think this is a canvas test and should
be in "fast/canvas".

Patch is OK as is, so review+ but I'm not setting commit-queue on this so you
have a chance to decide whether to make some additional refinements before
landing this.