[webkit-reviews] review requested: [Bug 43117] Chromium regression when viewing a plugin document with plugins disabled : [Attachment 63588] Remove assertion from PluginDocumentParser::appendBytes

[bugzilla-daemon at webkit.org]

Bernhard Bauer <bauerb at chromium.org> has asked	for review:
Bug 43117: Chromium regression when viewing a plugin document with plugins
disabled
https://bugs.webkit.org/show_bug.cgi?id=43117

Attachment 63588: Remove assertion from PluginDocumentParser::appendBytes
https://bugs.webkit.org/attachment.cgi?id=63588&action=review

------- Additional Comments from Bernhard Bauer <bauerb at chromium.org>
I looked into it a bit, and I think that simply removing the failing ASSERT
would be the right thing to do. appendBytes is called from FrameLoader::addData
and from DocumentWriter::endIfNotLoadingMainResource (with a NULL string in the
latter case), so the assumption that appendBytes is not called more than once
is definitely not true. On the next line is a check that returns if
m_embedElement already exists, so we also don't end up creating the document
more than once.