[webkit-reviews] review denied: [Bug 42970] [IndexedDB] IndexedDB is missing the Transaction interface. : [Attachment 63579] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Andrei Popescu
<andreip at google.com>'s request for review:
Bug 42970: [IndexedDB] IndexedDB is missing the Transaction interface.
https://bugs.webkit.org/show_bug.cgi?id=42970

Attachment 63579: Patch
https://bugs.webkit.org/attachment.cgi?id=63579&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/dom/EventNames.h:45
 +	macro(complete) \
what is this stuff?

WebCore/storage/IDBDatabase.idl:42
 +	    [CallWith=ScriptExecutionContext] IDBTransaction transaction (in
[Optional] DOMStringList storeNames, in [Optional] unsigned short mode, in
[Optional] unsigned long timeout);
not sure using domStringList as an input like this will work out of the
box....I don't think anyone's tried

WebCore/storage/IDBTask.h:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
use ScriptExecutionContext::Task and the CrossThreadTask stuff instead of
rolling your own

WebCore/storage/IDBTransaction.cpp:15
 +	: ActiveDOMObject(context, this), m_transaction(backend),
m_database(db)
put each on its own line

WebCore/storage/IDBTransaction.cpp:25
 +	return IDBTransaction::READ_ONLY;
Hook these up to the backend interface...I actually don't think you need any
FIXMEs in this file since all the work happens in the backend.

WebCore/storage/IDBTransaction.h:85
 +	RefPtr<IDBTransactionBackendInterface> m_transaction;
m_backend maybe?