[webkit-reviews] review requested: [Bug 41845] refactor identifier parsing in lexer : [Attachment 63582] identifier parsing patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 06:28:52 PDT 2010


Zoltan Herczeg <zherczeg at webkit.org> has asked	for review:
Bug 41845: refactor identifier parsing in lexer
https://bugs.webkit.org/show_bug.cgi?id=41845

Attachment 63582: identifier parsing patch
https://bugs.webkit.org/attachment.cgi?id=63582&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
This patch reaches the speed of the old code with gotos.

SunSpider --parse-only:
TEST			       COMPARISON	     FROM		  TO   
	 DETAILS

=============================================================================

** TOTAL **:		       -		 34.0ms +/- 2.2%   33.6ms +/-
1.5%

=============================================================================

  jquery:		       -		  5.2ms +/- 5.8%    5.1ms +/-
4.4%
    1.3.2:		       -		  5.2ms +/- 5.8%    5.1ms +/-
4.4%

  mootools:		       -		  5.7ms +/- 6.1%    5.4ms +/-
6.8%
    1.2.2-core-nc:	       -		  5.7ms +/- 6.1%    5.4ms +/-
6.8%

  prototype:		       -		  6.5ms +/- 5.8%    6.4ms +/-
5.8%
    1.6.0.3:		       -		  6.5ms +/- 5.8%    6.4ms +/-
5.8%

  concat:		       ??		 16.6ms +/- 2.2%   16.7ms +/-
2.1%	 not conclusive: might be *1.006x as slow*
    jquery-mootools-prototype: ??		 16.6ms +/- 2.2%   16.7ms +/-
2.1%	 not conclusive: might be *1.006x as slow*

Normal SunSpider reports no change.


More information about the webkit-reviews mailing list