[webkit-reviews] review granted: [Bug 41888] Initial bindings and plumbing for IDBCursor. : [Attachment 63462] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 41888: Initial bindings and plumbing for IDBCursor.
https://bugs.webkit.org/show_bug.cgi?id=41888

Attachment 63462: Patch
https://bugs.webkit.org/attachment.cgi?id=63462&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/WebCore.vcproj/WebCore.vcproj:50244
 +	    RelativePath="..\storage\IDBCursor.cpp"
intending is wrong

WebCore/storage/IDBCursor.h:48
 +	// Keep in sync with what's in the .idl file.
don't need this comment anymore, right?

WebCore/storage/IDBCursor.idl:31
 +	    // Keep in sync with what's in the .h file.
ditto?

WebCore/storage/IDBObjectStoreImpl.cpp:142
 +	callbacks->onSuccess(cursor.release());
Please double check this is what the spec specifies for the case that the key
doesn't exist.

WebCore/storage/IDBObjectStoreRequest.h:69
 +	PassRefPtr<IDBRequest> openCursor(ScriptExecutionContext*,
PassRefPtr<IDBKeyRange> range = 0, unsigned short direction = IDBCursor::NEXT);

do you have to define the variable name in order to do a default param?  if
not, delete "range"

WebKit/chromium/public/WebIDBKeyRange.h:55
 +	WebIDBKeyRange(const WTF::PassRefPtr<WebCore::IDBKeyRange>&);
if you do one, do all three

WebKit/chromium/src/WebIDBCursorImpl.cpp:71
 +  
extra new line


r=me