[webkit-reviews] review requested: [Bug 42865] Implement AccelerometerEvent : [Attachment 63546] New patch - Accelerometer is now DeviceMotion

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has asked  for review:
Bug 42865: Implement AccelerometerEvent
https://bugs.webkit.org/show_bug.cgi?id=42865

Attachment 63546: New patch - Accelerometer is now DeviceMotion
https://bugs.webkit.org/attachment.cgi?id=63546&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
This patch now uses DeviceMotionEvent rather than AccelerometerEvent to reflect
the fact that the event encapsulates accelerometer and gyroscopic data. It
seems the Geolocation WG have accepted the change, but the specification needs
to be updated.

I've rebased just now so hopefully it will patch against the current tree. I
was only a few hours out of date last time :)

I didn't mean to change the FeatureDefines in the previous patch. It's no
longer here. The custom v8 implementation is also changed.

The major change other than naming was to move the accessor functions in
DeviceMotionData to be inline. They are all one-liners.

Note that there are new results for the window-properties-device-orientation
test. Since this is skipped it would only be turned on when there is a client
implementation, and in that case you won't get the empty result. This will need
a V8 specific results file too.