[webkit-reviews] review granted: [Bug 43522] Change callback APIs to include an Error object in one callback, instead of having a second callback for failure. : [Attachment 63513] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 43522: Change callback APIs to include an Error object in one callback,
instead of having a second callback for failure.
https://bugs.webkit.org/show_bug.cgi?id=43522

Attachment 63513: Patch
https://bugs.webkit.org/attachment.cgi?id=63513&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> -
> +	   RefPtr<WebError> error = WebError::create();
> +	   m_callback(0, toRef(error.release().releaseRef()), m_context);

This would require the reciever of the callback to adopt the error, which I
don't think is what we want.  Instead, this should just call error.get().

If you change this, r=me.  Also, what Ada said.