[webkit-reviews] review granted: [Bug 43467] Allow the language for hyphenation to be specified : [Attachment 63488] Add -webkit-hyphenate-locale

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 43467: Allow the language for hyphenation to be specified
https://bugs.webkit.org/show_bug.cgi?id=43467

Attachment 63488: Add -webkit-hyphenate-locale
https://bugs.webkit.org/attachment.cgi?id=63488&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
 +			i = m_cache.size();
I'd find it slightly clearer if, rather than reassigning to 'i', you used a new
variable ("foundIndex" or something). Took me a while to grok why you
reassigned to i.

WebCore/platform/text/cf/HyphenationCF.cpp:66
 +  //	  RetainPtr<CFLocaleRef> locale =
getCachedLocaleProperty<LocaleCFLocale>(localeIdentifier);
Remove commented code?