[webkit-reviews] review granted: [Bug 43450] Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI. : [Attachment 63480] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Kavita Kanetkar
<kkanetkar at chromium.org>'s request for review:
Bug 43450: Web Inspector: Remove "Online/Offline" icon for Chrome's appcache
devtools UI.
https://bugs.webkit.org/show_bug.cgi?id=43450

Attachment 63480: patch
https://bugs.webkit.org/attachment.cgi?id=63480&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
(In reply to comment #2)
> From what I understand, we always returns true for navigator.onLine.
> I am disabling UI for chrome-only. It probably is confusing to end-users
> to see it always "Online". Please take a look at the patch.

Any idea why Chrome always returns true? Is there an open bug
for this feature to be implemented? Can you create a bug or
link me to it?

Finally, can you file a follow up bug to re-enable the feature for
Chrome pending the feature being implemented?

Anyways, the patch looks good to me, just the open questions.