[webkit-reviews] review denied: [Bug 41988] [QT] WebKit fails to build against Qt QPA / Lighthouse : [Attachment 61218] patch updated with changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 12:58:17 PDT 2010


Simon Hausmann <hausmann at webkit.org> has denied Jamey Hicks
<jamey.hicks at nokia.com>'s request for review:
Bug 41988: [QT] WebKit fails to build against Qt QPA / Lighthouse
https://bugs.webkit.org/show_bug.cgi?id=41988

Attachment 61218: patch updated with changelog
https://bugs.webkit.org/attachment.cgi?id=61218&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Patch looks fine to me, but could you fix up the ChangeLog? :)

The indentation is off, there shouldn't be a "No new tests. (OOPS!)" line and
maybe add a "[Qt]" suffix in front of the "enable build against Qt lighthouse"
title.


More information about the webkit-reviews mailing list