[webkit-reviews] review requested: [Bug 25645] SVG - numeric overflow for very large elements : [Attachment 63464] Re-baseline massive-coordinates.svg test expectations for platform/win.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 10:25:57 PDT 2010


W. James MacLean <wjmaclean at chromium.org> has asked  for review:
Bug 25645: SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645

Attachment 63464: Re-baseline massive-coordinates.svg test expectations for
platform/win.
https://bugs.webkit.org/attachment.cgi?id=63464&action=review

------- Additional Comments from W. James MacLean <wjmaclean at chromium.org>
This patch re-baselines the expected output for
LayoutTests/svg/custom/massive-coordinates.svg for platform/win. The change
appears to just be a numeric precision/round-off issue.

This patch also removes the expected output for
LayoutTests/svg/custom/pattern-excessive-malloc.svg for the GTK platform, as
the current expected output is *very broken*. This test, along with that for
LayoutTests/svg/custom/massive-coordinates.svg needs to be re-baselined for
GTK, but I think it is likely better not to test against a known bad
-expected.txt file in the meantime. Since all other platforms seem to be in
close agreement, I suspect this is a debugging-output issue in GTK.

Both tests expectations for Qt were re-baselined in
https://bugs.webkit.org/show_bug.cgi?id=43361 (thanks Martin Robinson!).


More information about the webkit-reviews mailing list