[webkit-reviews] review granted: [Bug 43477] Add speech input controller mock in WebKit and a layout test. : [Attachment 63450] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 09:56:11 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Satish Sampath
<satish at chromium.org>'s request for review:
Bug 43477: Add speech input controller mock in WebKit and a layout test.
https://bugs.webkit.org/show_bug.cgi?id=43477

Attachment 63450: Patch
https://bugs.webkit.org/attachment.cgi?id=63450&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp:69
 +	const WebCore::String& result)
put on one line

WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp:52
 +  void WebSpeechInputControllerMockImpl::setMockRecognitionResult(
ditto

WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp:39
 +  // Factory method.
comment not needed

WebKit/chromium/public/WebSpeechInputControllerMock.h:43
 +	static WebSpeechInputControllerMock* create(WebSpeechInputListener*
listener);
Add virtual destructor.

r=me


More information about the webkit-reviews mailing list