[webkit-reviews] review requested: [Bug 43448] [Qt] [QtTestBrowser] Clean up static and global menu state controls : [Attachment 63457] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 09:13:34 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 43448: [Qt] [QtTestBrowser] Clean up static and global menu state controls
https://bugs.webkit.org/show_bug.cgi?id=43448

Attachment 63457: patch v1
https://bugs.webkit.org/attachment.cgi?id=63457&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
After LauncherWindow class was refactored out of from main.cpp, all global
variables that were anging in main.cpp became temporarily public static class
members of newly added LauncherWindow class. This design was not properly
handling the initial purpose of the global variables: newly created launcher
windows should inherit the settings of the originating one.
    
In order to properly fix the problem, this patch introduces a LauncherData
class, as a POD. It comprises all data needed to handling the goal described
above.


More information about the webkit-reviews mailing list