[webkit-reviews] review denied: [Bug 43258] Implement chromium WebDeviceOrientationClient wrapper and have WebViewImpl get it from WebViewClient. : [Attachment 63432] WebDeviceOrientationClient plus plumbing

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied  review:
Bug 43258: Implement chromium WebDeviceOrientationClient wrapper and have
WebViewImpl get it from WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=43258

Attachment 63432: WebDeviceOrientationClient plus plumbing
https://bugs.webkit.org/attachment.cgi?id=63432&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebKit/chromium/public/WebViewClient.h:94
 +	virtual WebDeviceOrientationClient* createWebDeviceOrientationClient()
{ return WebDeviceOrientationClientMock::create(); }
Remove.  Just call WebDeviceOrientationClientMock::create directly.

WebKit/chromium/src/WebViewImpl.h:526
 +	OwnPtr<WebDeviceOrientationClient> m_webDeviceOrientationClient;
delete

WebKit/chromium/src/WebViewImpl.h:79
 +  class WebDeviceOrientationClient;
delete

WebKit/chromium/src/WebViewImpl.cpp:268
 +	,
m_webDeviceOrientationClient(WebRuntimeFeatures::isDeviceOrientationEnabled() ?
(client ? client->createWebDeviceOrientationClient() :
WebDeviceOrientationClientMock::create()) : 0)
delete

WebKit/chromium/src/WebViewImpl.cpp:292
 +	if (m_webDeviceOrientationClient)
this is all obsolete

WebKit/chromium/src/WebViewImpl.cpp:2216
 +	    m_webDeviceOrientationClient->updateOrientation(o);
The WebViewImpl should be calling some web core method directly to tell it of
the update.


I believe the only new files you should have in this patch are
WebDeviceOrientationClientMock.cpp/h and DeviceOrientationClientProxy (which
will have a pointer to the WebViewClient and pass stuff on to that).  If you
need anything more I suggest you run it by me first.

I'd highly suggest you get all of this compiling/working together on a local
machine before posting another patch.  It'll help clarify the design, I think.