[webkit-reviews] review denied: [Bug 42865] Implement AccelerometerEvent : [Attachment 63374] Updated patch

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 42865: Implement AccelerometerEvent
https://bugs.webkit.org/show_bug.cgi?id=42865

Attachment 63374: Updated patch
https://bugs.webkit.org/attachment.cgi?id=63374&action=review

------- Additional Comments from Steve Block <steveblock at google.com>

WebCore/Configurations/FeatureDefines.xcconfig:64
 +  ENABLE_DEVICE_ORIENTATION = ENABLE_DEVICE_ORIENTATION;
If you want to change this file, you must also change the corresponding file in
JavaScriptCore and WebKit/mac. See the header of this file.

WebCore/bindings/v8/custom/V8AccelerometerEventCustom.cpp:41
 +	INC_STATS("DOM.DeviceOrientationEvent.x._get");
Should be AccelerometerEvent

Looks good other than the two minor points above.

It would be good if you could rebase your patch before you upload next time, so
that it can build on the EWS bots. It's easy to introduce a build break with a
patch like this that adds new files.